Issue-693: Disallow scheduler on locked pages (when scheduler module is enabled) #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
November 14, 2024 13:05
sonvir249
changed the title
|
Thanks. As tests are not running on forked PRs, can you please attach screenshots of phpstan, phpcs and phpunit executed. |
@amitaibu Please check the attached screenshots of phpstan, phpcs and phpunit commands.
|
|
Thanks, can you execute all tests please. |
I have fixed a phpstan test case issue in a0b8773
|
amitaibu
reviewed
Dec 18, 2024
| */ | ||
| function server_general_scheduler_unpublishing_allowed(NodeInterface $entity) { | ||
| // Do nothing if node is not a landing page. | ||
| if ($entity->bundle() !== 'landing_page') { |
There was a problem hiding this comment.
Let's confirm also that entity type is node
There was a problem hiding this comment.
@amitaibu I'm already passing NodeInterface as an argument. Do we still need to explicitly check for entity type node ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #693