Custom property for partial message text tokens. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgullstr Thanks, any chance for adding a test? @RoySegall please review. |
|
@amitaibu As this approach is dependent on the chained token issue being resolved in Entity token, I'll wait until that is fixed prior to spending any time on writing tests. |
|
Oops, accidental close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, AFAIK, there's no way to get a token for a single delta value for a message text. I have a message type, where text (delta 0) holds an SMS text and (delta 1) holds an email texts. Both SMS and e-mails are sent by Rules, and I need to retrieve the delta values as tokens to their respective rule.
I've added a property, that retrieves the texts as a list, so tokens can use the delta values.
In order for this to work, there's an issue with chained tokens and Entity tokens that needs to be resolved. (See here)