Fix test_deprecate to work with setuptools_scm versions
#429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, and works on my local machine too - thanks @rhugonnet |
atedstone
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See more details on the issue here: #427 (comment)
Was failing locally but not in CI because of link between
gitandsetuptools_scmfor versioning. Now usingVersionobjects to have things consistent everywhere! (easy to change our deprecated mechanism in the future if we want to, by extracting a different major/minor/micro version from the Version object 😄)Tested locally with:
__version__ = version = '0.0.18.dev4+g90460bf'rcsuffix attached to last version number:__version__ = version = '0.0.17rc2.dev1+gef706f8'Both passing!
Resolves #427