-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User can define the threshold of the room humitidy #1877
User can define the threshold of the room humitidy #1877
Conversation
4a7e377
to
e67ac1a
Compare
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Job #1814: Bundle Size — 8.69MiB (+0.32%).
Metrics (4 changes)
Total size by type (2 changes)
View job #1814 report View callemand:mix_max_temp_humi branch activity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Great job 👏
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add a threshold for the room humidity widget