-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zWaveJS] New features suport : Battery, Illuminance, Binary Sensor, Alarm Sensor #2198
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2198 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 876 877 +1
Lines 14455 14515 +60
=======================================
+ Hits 14244 14304 +60
Misses 211 211 ☔ View full report in Codecov by Sentry. |
#3001 Bundle Size — 10.42MiB (+0.02%).de45254(current) vs 90757c1 master#2994(baseline) Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #3001 |
Baseline #2994 |
|
---|---|---|
Initial JS | 5.65MiB (+0.04% ) |
5.65MiB |
Initial CSS | 304.87KiB |
304.87KiB |
Cache Invalidation | 54.1% |
0% |
Chunks | 51 |
51 |
Assets | 173 |
173 |
Modules | 1512 |
1512 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.83% |
0.83% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 6 changes
6 regressions
Current #3001 |
Baseline #2994 |
|
---|---|---|
JS | 7.44MiB (+100% ) |
undefined |
IMG | 2.54MiB (+100% ) |
undefined |
CSS | 321.77KiB (+100% ) |
undefined |
Fonts | 93.55KiB (+100% ) |
undefined |
Other | 17.79KiB (+100% ) |
undefined |
HTML | 13.58KiB (+100% ) |
undefined |
Bundle analysis report Branch sescandell:zjs-battery Project dashboard
Generated by RelativeCI Documentation Report issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I have a question about "general-sensor"
front/src/config/i18n/fr.json
Outdated
@@ -3026,6 +3026,11 @@ | |||
"shortCategoryName": "Batterie faible", | |||
"binary": "Batterie faible (Oui/Non)" | |||
}, | |||
"general-sensor": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is a "general-sensor"?
48a04c0
to
9b027cc
Compare
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)If you are adding a new features/services, did you run integration comparator? (npm run compare-translations
on front)If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.Did you add fake requests data for the demo mode (front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Adding support for the following command classes:
Tested on real device for the battery part:
Ready to merge