Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zWaveJS] New features suport : Battery, Illuminance, Binary Sensor, Alarm Sensor #2198

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

sescandell
Copy link
Contributor

@sescandell sescandell commented Jan 18, 2025

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Adding support for the following command classes:

  • Battery Level
  • Battery IsLow
  • Illuminance
  • Binary Sensor
  • Alarm Sensor handling State only

Tested on real device for the battery part:
image

image

Ready to merge

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (90757c1) to head (9b027cc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2198   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         876      877    +1     
  Lines       14455    14515   +60     
=======================================
+ Hits        14244    14304   +60     
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jan 18, 2025

#3001 Bundle Size — 10.42MiB (+0.02%).

de45254(current) vs 90757c1 master#2994(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#3001
     Baseline
#2994
Regression  Initial JS 5.65MiB(+0.04%) 5.65MiB
No change  Initial CSS 304.87KiB 304.87KiB
Change  Cache Invalidation 54.1% 0%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1512 1512
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 6 changes Regression 6 regressions
                 Current
#3001
     Baseline
#2994
Regression  JS 7.44MiB (+100%) undefined
Regression  IMG 2.54MiB (+100%) undefined
Regression  CSS 321.77KiB (+100%) undefined
Regression  Fonts 93.55KiB (+100%) undefined
Regression  Other 17.79KiB (+100%) undefined
Regression  HTML 13.58KiB (+100%) undefined

Bundle analysis reportBranch sescandell:zjs-batteryProject dashboard


Generated by RelativeCIDocumentationReport issue

@sescandell sescandell changed the title [zWaveJS] Support Battery command class [zWaveJS] Support Battery command class & Illuminance Sensors Jan 18, 2025
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I have a question about "general-sensor"

@@ -3026,6 +3026,11 @@
"shortCategoryName": "Batterie faible",
"binary": "Batterie faible (Oui/Non)"
},
"general-sensor": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a "general-sensor"?

@sescandell sescandell changed the title [zWaveJS] Support Battery command class & Illuminance Sensors [zWaveJS] New features suport : Battery, Illuminance, Binary Sensor, Alarm Sensor Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants