Fixed underground temperature modifier being used for non-overworld b…

…iomes
Glitchfiend · Jan 5, 2024 · 71c6c9f · 71c6c9f
1 parent 054a539
commit 71c6c9f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/common/src/main/java/toughasnails/temperature/TemperatureHelperImpl.java b/common/src/main/java/toughasnails/temperature/TemperatureHelperImpl.java
@@ -8,6 +8,7 @@
 import com.google.common.collect.Sets;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Holder;
+import net.minecraft.tags.BiomeTags;
 import net.minecraft.tags.FluidTags;
 import net.minecraft.world.entity.player.Player;
 import net.minecraft.world.entity.vehicle.Boat;
@@ -131,7 +132,7 @@ private static TemperatureLevel getBiomeTemperatureLevel(Level level, BlockPos p
         Holder<Biome> biome = level.getBiome(pos);
         float biomeTemperature = biome.value().getBaseTemperature();
 
-        if (pos.getY() > ModConfig.temperature.environmentalModifierAltitude || level.canSeeSky(pos))
+        if (!biome.is(BiomeTags.IS_OVERWORLD) || (pos.getY() > ModConfig.temperature.environmentalModifierAltitude || level.canSeeSky(pos)))
         {
             if (biome.is(ModTags.Biomes.ICY_BIOMES)) return TemperatureLevel.ICY;
             else if (biome.is(ModTags.Biomes.COLD_BIOMES)) return TemperatureLevel.COLD;

diff --git a/forge/src/main/java/toughasnails/forge/init/ModCompatibility.java b/forge/src/main/java/toughasnails/forge/init/ModCompatibility.java
@@ -6,6 +6,7 @@
 
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Holder;
+import net.minecraft.tags.BiomeTags;
 import net.minecraft.world.level.Level;
 import net.minecraft.world.level.biome.Biome;
 import net.minecraftforge.fml.ModList;
@@ -39,7 +40,7 @@ private static TemperatureLevel seasonModifier(Level level, BlockPos pos, Temper
         Holder<Biome> biome = level.getBiome(pos);
 
         // Only adjust if above the environmental modifier altitude
-        if (pos.getY() <= ModConfig.temperature.environmentalModifierAltitude && !level.canSeeSky(pos))
+        if (biome.is(BiomeTags.IS_OVERWORLD) && pos.getY() <= ModConfig.temperature.environmentalModifierAltitude && !level.canSeeSky(pos))
             return current;
 
         // Check if biome uses seasonal effects