Remove confusing error message for unauthenticated API calls (libopen…

…storage#1489) Signed-off-by: Grant Griffiths <[email protected]>
Glitchfix · Apr 3, 2020 · 9a43a98 · 9a43a98
1 parent 0840cd6
commit 9a43a98
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/api/server/sdk/server_interceptors.go b/api/server/sdk/server_interceptors.go
@@ -152,6 +152,12 @@ func (s *sdkGrpcServer) authorizationServerInterceptor(
 	// Authorize
 	if err := s.roleServer.Verify(ctx, claims.Roles, info.FullMethod); err != nil {
 		logger.Warning("Access denied")
+		if auth.IsPublic(ctx) {
+			return nil, status.Errorf(
+				codes.PermissionDenied,
+				"Access denied without authentication token")
+		}
+
 		return nil, status.Errorf(
 			codes.PermissionDenied,
 			"Access to %s denied: %v",

diff --git a/api/server/sdk/server_interceptors_test.go b/api/server/sdk/server_interceptors_test.go
@@ -50,7 +50,7 @@ func TestAuthorizationServerInterceptorCreate(t *testing.T) {
 			RequestAuthenticated:         false,
 
 			ExpectSuccess: false,
-			ExpectedError: "rpc error: code = PermissionDenied desc = Access to /openstorage.api.OpenStorageVolume/Create denied: rpc error: code = PermissionDenied desc = Access denied to roles: [system.public]",
+			ExpectedError: "rpc error: code = PermissionDenied desc = Access denied without authentication token",
 		},
 		{
 			TestName:                     "2-1: Authenticated volume creation should succeed with public vol creation enabled",