This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Additions for improved BlockType-system (adds hay, ender-portal-frame, improved lever-facing) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,47 +102,76 @@ public void setFacingDirection(BlockFace face) { | |||
| byte data = (byte) (getData() & 0x8); | |||
| BlockFace attach = getAttachedFace(); | |||
|
|
|||
| if (attach == BlockFace.DOWN) { | |||
There was a problem hiding this comment.
What is going on here? There appears to be several changes that do not need to be made
|
@Tonodus Your PR has several formatting concerns. Please see the repository's contributing guidelines. |
Tonodus
force-pushed
the
BBT
branch
3 times, most recently
from
e9470b8 to
236c873
Compare
|
@turt2live I hope I resolved the formatting concerns. |
| import org.bukkit.block.BlockFace; | ||
| import org.bukkit.Material; | ||
|
|
||
| public class EnderPortalFrame extends MaterialData implements Directional { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes are needed for this PR: GlowstoneMC/Glowstone#566 (improved Block/ItemType-System).
Adds:
Modifies:
Edited by turt2live