Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding some of the default extensions back and adding liveshare #202

Conversation

venkatamutyala
Copy link
Contributor

@venkatamutyala venkatamutyala commented Nov 19, 2024

PR Type

enhancement, configuration changes


Description

  • Added the MS-vsliveshare.vsliveshare extension to the Dockerfile to enable Live Share functionality.
  • Added the GitHub.codespaces extension to the Dockerfile to support GitHub Codespaces features.

Changes walkthrough 📝

Relevant files
Enhancement
Dockerfile
Add Live Share and GitHub Codespaces extensions                   

.devcontainer/Dockerfile

  • Added installation of MS-vsliveshare.vsliveshare extension.
  • Added installation of GitHub.codespaces extension.
  • +3/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Installation Order
    The VS Code extensions are installed after switching to the vscode user. Consider installing extensions before the USER switch to ensure proper permissions.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Optimize Docker image size by combining multiple RUN commands into a single instruction

    Combine multiple RUN commands for VS Code extensions into a single RUN instruction
    to reduce the number of layers in the Docker image and optimize its size.

    .devcontainer/Dockerfile [143-144]

    -RUN code --install-extension MS-vsliveshare.vsliveshare --extensions-dir /home/vscode/.vscode-remote/extensions
    -RUN code --install-extension GitHub.codespaces --extensions-dir /home/vscode/.vscode-remote/extensions
    +RUN code --extensions-dir /home/vscode/.vscode-remote/extensions \
    +    --install-extension MS-vsliveshare.vsliveshare \
    +    --install-extension GitHub.codespaces
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Combining multiple RUN commands into a single instruction is a Docker best practice that reduces the number of layers and optimizes image size. This suggestion correctly identifies and addresses this optimization opportunity.

    7

    💡 Need additional feedback ? start a PR chat

    @venkatamutyala venkatamutyala merged commit 570b2d1 into main Nov 19, 2024
    3 checks passed
    @venkatamutyala venkatamutyala deleted the feat-adding-some-of-the-default-extensions-back-and-adding-liveshare branch November 19, 2024 05:39
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants