fix: refactor hetzner code

GlueOps · Sep 28, 2024 · d527ae7 · d527ae7
1 parent 568abb1
commit d527ae7
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 22 deletions.
diff --git a/bot/example.env b/bot/example.env
@@ -1,9 +1,8 @@
 SIGNING_SECRET=<SLACK Bot signing Secret>
 BOT_TOKEN=<Slack Bot Token>
 APP_TOKEN=<Slack Bot App Token>
-BOLT_PORT=3000
 SERVER_PORT=5000
-HETZNER_API_TOKEN=<Hetzner API Token>
 TAILSCALE_API_TOKEN=<Tailscale API Token>
 TAILSCALE_AUTH_KEY=<Tailscale Auth Key>
-TAILSCALE_TAILNET_NAME=<Tailscale Tailnet Name>
+TAILSCALE_TAILNET_NAME=<Tailscale Tailnet Name>
+HETZNER_API_TOKEN=<Hetzner API Token>
diff --git a/command-handler/src/util/get-servers.js b/command-handler/src/util/get-servers.js
@@ -5,8 +5,8 @@ import logger from './logger.js';
 
 const log = logger();
 
-export default async function getServer() {
-    const data = await axios.get('https://api.hetzner.cloud/v1/servers', {
+export default async function getServer(serverId = "") {
+    const data = await axios.get(`https://api.hetzner.cloud/v1/servers/${serverId}`, {
         headers: {
           'Authorization': `Bearer ${process.env.HETZNER_API_TOKEN}`
         }

diff --git a/command-handler/src/util/hetzner-servers.js b/command-handler/src/util/hetzner-servers.js
@@ -62,8 +62,9 @@ export default {
       });
 
       //hetzner api to create the server
+      let serverRes;
       try {
-        await axios.post('https://api.hetzner.cloud/v1/servers', 
+        serverRes = await axios.post('https://api.hetzner.cloud/v1/servers', 
           {
             "automount": false,
             "image": imageID,
@@ -97,18 +98,44 @@ export default {
         return;
       }
 
-      const maxRetries = 20;
+      let maxRetries = 20;
       let attempts;
 
       for (attempts = 1; attempts <= maxRetries; attempts++) {
-        //set tag in tailscale
+        //wait 30 seconds
+        await delay(1000 * 30);
+
+        const server = await getServer(serverRes.data.server.id);
+
+        if (server.data.server.status === 'running') {
+          break;
+        } else {
+          log.info(`Attempt ${attempts} Failed. Backing off for 30 seconds`);
+        }
+      }
+
+      if (attempts === maxRetries) {
         try {
-          //wait 30 seconds
-          await delay(1000 * 30);
+          throw new Error(`Failed to initialize server in hetzner after ${attempts} retries`);
+        } catch (error) {
+            log.error({message: error.message, stack: error.stack});
+            app.client.chat.postEphemeral({
+              channel: `${body.channel.id}`,
+              user: `${body.user.id}`,
+              text: `Failed to initialize server in Hetzner`
+            });
+            return;
+        } 
+      }
 
+    maxRetries = 4;  
+    for (attempts = 1; attempts <= maxRetries; attempts++) {
+        //wait 30 seconds
+        await delay(1000 * 30);
+        try {
           //get servers and info from tailscale
           const { deviceId } = await getDevices(serverName);
-
+  
           await axios.post(`https://api.tailscale.com/api/v2/device/${deviceId}/tags`, 
             {
               "tags": [
@@ -120,25 +147,23 @@ export default {
               'Content-Type': 'application/json'
             }
           });
-
-          //break out of the function if successful
           break;
         } catch (error) {
-          log.info(`Attempt ${attempts} Failed. Backing off for 30 seconds`)
-        }
+            log.info(`Attempt ${attempts} Failed. Backing off for 30 seconds`)
+          }
       }
 
       if (attempts === maxRetries) {
         try {
           throw new Error(`Failed to set tags in tailscale after ${attempts} retries`);
         } catch (error) {
-          log.error({message: error.message, stack: error.stack});
-          app.client.chat.postEphemeral({
-            channel: `${body.channel.id}`,
-            user: `${body.user.id}`,
-            text: `Failed to set tags in tailscale`
-          });
-          return;
+            log.error({message: error.message, stack: error.stack});
+            app.client.chat.postEphemeral({
+              channel: `${body.channel.id}`,
+              user: `${body.user.id}`,
+              text: `Failed to set tags in tailscale`
+            });
+            return;
         }
       }