Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v1.82.1 #104

Closed
wants to merge 1 commit into from
Closed

Prepare v1.82.1 #104

wants to merge 1 commit into from

Conversation

JamesWrigley
Copy link
Collaborator

This is a patch release that fixes compat bounds for some dependencies, which were previously allowing newer-than-actually-compatible versions. See: #100 (comment)

The main change here is to remove the unions from the bounds of ImGuiGLFWBackend.jl, ImGuiOpenGLBackend.jl, and LibCImGui.jl. e.g. ~1.82, 1 for LibCImGui.jl means that the allowed versions would be [1.82 - 1.83) union [1 - 2) (if I read the docs correctly), which is not correct since LibCImGui.jl 1.89 is breaking but would still be allowed by that second bound.

This is a patch release that fixes compat bounds for some dependencies, which
were previously allowing newer-than-actually-compatible versions.
@JamesWrigley JamesWrigley requested a review from Gnimuc November 10, 2023 22:23
@JamesWrigley JamesWrigley self-assigned this Nov 10, 2023
@JamesWrigley
Copy link
Collaborator Author

Oops, I forgot that this should be merged to the release-1.82 branch rather than master 🤦 Going to open a new one.

@JamesWrigley JamesWrigley mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant