1.90.8 and backend shenanigans #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesWrigley
force-pushed
the
1.90.8
branch
2 times, most recently
from
97a335a to
244c36c
Compare
JamesWrigley
force-pushed
the
1.90.8
branch
2 times, most recently
from
bc37505 to
240f2df
Compare
JamesWrigley
force-pushed
the
1.90.8
branch
3 times, most recently
from
0b799ae to
664b68d
Compare
|
Fixes #123. Sneaky proof using the new test engine wrapper 😏 |
This was
linked to
issues
Jun 24, 2024
Closed
JamesWrigley
force-pushed
the
1.90.8
branch
6 times, most recently
from
f1a6bd4 to
edcc4f9
Compare
|
While fixing the existing tests and getting CI to pass I realized that package extensions were only added in 1.9... I don't think I can be bothered supporting Requires and all that for older versions so I just bumped the minimum Julia version. |
JamesWrigley
force-pushed
the
1.90.8
branch
3 times, most recently
from
a29b573 to
aa8b859
Compare
JamesWrigley
force-pushed
the
1.90.8
branch
2 times, most recently
from
844760a to
46887cd
Compare
This involved using a method to set the backend instead of a global variable for compatibility with Julia 1.6, though eventually I decided to bump the minimum Julia version to 1.9 so we could get package extensions.
|
I tried to add x86 tests to CI, but got this error when creating a GLFW window: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I began the bindings update to 1.90.8 and ran into a bunch of things that needed fixing in our backends, so I decided to try using the official GLFW/OpenGL3 backends instead. And amazingly, they seem to work 🐙 This isn't ready to merge yet but I'm opening it for transparency.
demo/demo.jlshould work, but notexample/demo.jlyet.How to test it:
Clone my
cimguipack-updatebranch of Yggdrasil ([CImGuiPack] Update to ImGui 1.90.8 JuliaPackaging/Yggdrasil#8870)Build
CImGuiPacklocally with:julia +1.7 build_tarballs.jl <platform> --deploy=local. Change the platform to your desired one, for example (in a project withBinaryBuilderandBinaryBuilderBaseinstalled):If you get configure errors about
cxx_std_20, pick a target that's in this CI list that matches your system: https://buildkite.com/julialang/yggdrasil/builds/11093. For example, on my system I had to usex86_64-linux-gnu-cxx11-julia_version+1.11.0.Clone this branch,
] dev ./LibCImGui.jland] dev CImGuiPack, and rundemo/demo.jl. Docking and multiple viewports should work.