Allow code.gnucash.org/website as DEFAULT_URL #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekatkins
reviewed
Mar 20, 2023
| @@ -79,7 +79,12 @@ | |||
| $latest_unstable_source="gnucash-".$latest_unstable.".tar.bz2"; | |||
|
|
|||
| // The URLs, we use: | |||
| define("DEFAULT_URL", "https://www.gnucash.org/"); // The main webserver | |||
| if (gethostname()=="code") { | |||
There was a problem hiding this comment.
hostname /may/ return "code.gnucash.org" -- I don't know what it will return specifically.
the hostname command-line tool returns the FQDN.
There was a problem hiding this comment.
gethostname might well return just 'code'. It's apparently implementation and OS dependent. The only way to tell is to apply the patch and then look at the resulting page source in a browser.
There was a problem hiding this comment.
or we we use something like
if ((gethostname()=="code") or (gethostname()=="code.gnucash.org"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing this should be a clean substitution for @derekatkins local patch.