Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Price Import Assistant clarity #1789

Open
wants to merge 3 commits into
base: stable
Choose a base branch
from
Open

Improve Price Import Assistant clarity #1789

wants to merge 3 commits into from

Conversation

flywire
Copy link
Contributor

@flywire flywire commented Sep 30, 2023

No description provided.

@jralls
Copy link
Member

jralls commented Sep 30, 2023

The first sentence is better, but it's sort of negated by the second. How about

The importer needs at least Date and Price columns when importing prices for a single commodity and currency pair set in the Commodity From and Currency To drop-downs. To import prices multiple commodities the importer requires Date, Amount, From Namespace, From Symbol and Currency To columns.

@flywire
Copy link
Contributor Author

flywire commented Sep 30, 2023 •
edited
Loading

Fair point, it needs further work below too. Let's see what comes up in the list discussion which runs into next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flywire @jralls