Gnc plugin page register to cpp #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherlam
force-pushed
the
gnome-to-cpp
branch
3 times, most recently
from
5e1c457
to
1cac433
Compare
|
That's a rather expansive PR title. "Plugin page register to C++" would be better. "CPP" is ambiguous because it can also mean the C pre-processor, the program that handles |
jralls
reviewed
Feb 24, 2024
| @@ -3898,29 +3898,31 @@ gnc_plugin_page_register_cmd_reverse_transaction (GSimpleAction *simple, | |||
| { | |||
| const char *rev = _("A reversing entry has already been created for this transaction."); | |||
| const char *jump = _("Jump to the transaction?"); | |||
| if (gnc_verify_dialog (GTK_WINDOW (window), TRUE, "%s\n\n%s", rev, jump)) | |||
| goto jump_to_trans; | |||
There was a problem hiding this comment.
A better way to accomplish this would be to extract into new functions the two blocks, say maybe_jump_to_existing and maybe_create_reverse_transaction, then
if (auto new_trans{xaccTransactionGetReversedBy(trans)
{
if (!maybe_jump_to_existing(/*…*/))
{
LEAVE ("reverse already exists");
return;
}
}
else
{
if (!maybe_create_reverse_transaction(/*…*/))
{
LEAVE ("reverse cancelled");
return;
}
}
bda5145
to
ade9d6d
Compare
|
uhm. maybe i'll split this into cpp conversion and cppisms in another branch. |
christopherlam
force-pushed
the
gnome-to-cpp
branch
2 times, most recently
from
782e114
to
810e4fd
Compare
…ctor<gncInvoice*>
reorder logic to avoid using goto
launches time64 input dialog
christopherlam
force-pushed
the
gnome-to-cpp
branch
from
810e4fd
to
6b1944f
Compare
code-gnucash-org
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and will rebase #1873 on top of this.