[gnc-datetime] add boost UK/US/ISO date parsers #2015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherlam
force-pushed
the
csv-boost-date
branch
from
2b9053e
to
7a5c5d1
Compare
Thus "30 Sep 2024" and "30 September 2024" are accepted. But ICU's "30 Sept 2024" is rightfully rejected.
christopherlam
force-pushed
the
csv-boost-date
branch
from
7a5c5d1
to
69bf156
Compare
As @jralls already remarked on #1710 , the issue remains that this solution is very limited. It solves your case, but will not add anything for non-English speaking regions. If we merge this I expect users to request similar options for other regions, which we can't offer via boost. |
|
Closed in favour of #2011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1710 (comment)
UK: "30 Sep 2024" and "30 September 2024" are accepted. "30 Sept 2024" is rejected.
US: "May 2, 2024" is accepted.
ISO delimited: "2024 Dec 20" and "2024 December 20" are accepted.
Note boost's parser requires 4-digit years.