Don't let udev reload cause the installation to fail #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may need to be applied to |
I was just wondering, why my Vanilla OS image still doesn't want to build xD |
|
https://github.com/marvin-te/vanillaos/actions/runs/10493124757/job/29066330762#step:10:1246 Works as expected (image build still fails, though because of another, unrelated package) |
|
Thanks, have you done any install checks on RPM based distros with these changes? I'm not in a position where I can easily test the builds, and obviously want to avoid pushing something which isn't tested. |
|
Hi @FrostyCoolSlug, I understand. Sadly though I do not have a full RPM based system at hand either. I tried to install it inside a container in Vanilla OS, which worked fine. Since these don't have udev either, the error message introduced in this PR appeared as expected. Thus I could not check if the udev-reload itself still works, though. But I cannot see any reason why it shouldn't. Hope this helps. If further testing is needed, I hope someone can try to install the .rpm from this PR on bare metal. A pre-built one can be found on the release page of my fork: goxlr-utility-1.1.2-1.x86_64.rpm Full shell transcript from testing:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less a follow up to my PR #128 from almost a year ago.
I encountered different occasions, where trying to reload the udev rules fails. Most package managers will cancel the whole installation when this happens, which is not always the right thing to do in such case.
This PR broadens the failure tolerance from "only OSTree-based systems don't need a udev reload" to "if it works, it works, if not, ¯\(ツ)/¯"
The reason behind this proposed change is this error when installing GoXLR Utility in my custom Vanilla OS image: https://github.com/marvin-te/vanillaos/actions/runs/10491093490/job/29059376736#step:10:1257