Fixes #235 missing TARGET on map::erase()

ChangeLog.MD

@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+### Fixed
+
+- Added missing TARGET attribute in map::erase() procedures.  When
+  used with NAG compiler, would result in temporary objects with
+  dangling pointers. Added new test to cover this case.
+
 ## [1.14.0] - 2024-07-09
 
 ### Fixed

include/v2/map/procedures.inc

@@ -248,7 +248,7 @@
       ! =======================
       function __MANGLE(erase_iter)(this, iter) result(new_iter)
          type(__map_iterator) :: new_iter
-         class(__map), intent(inout) :: this
+         class(__map), target, intent(inout) :: this
          type(__map_iterator), intent(in) :: iter
 
          new_iter%reference => iter%reference
@@ -261,7 +261,7 @@
       ! =======================
       function __MANGLE(erase_key)(this, k) result(n)
          integer(kind=GFTL_SIZE_KIND) :: n
-         class(__map), intent(inout) :: this
+         class(__map), target, intent(inout) :: this
          __Key_declare_dummy__, intent(in) :: k
 
          type(__map_iterator) :: iter

tests/map/Test_Map.m4

@@ -179,6 +179,25 @@ contains
 
    end subroutine test_erase
 
+@test
+   subroutine test_erase_key()
+      type (Map), target :: m
+      integer :: n
+
+      call m%insert(key_one, one)
+      call m%insert(key_two, two)
+      call m%insert(key_three, three)
+
+      n = m%erase(key_two)
+      @assert_that(n, is(equal_to(1)))
+      @assert_that(int(m%size()), is(equal_to(2)))
+
+      n = m%erase(key_zero)
+      @assert_that(n, is(equal_to(0)))
+      @assert_that(int(m%size()), is(equal_to(2)))
+
+   end subroutine test_erase_key
+
 @test
    subroutine test_next()
       type (Map), target :: m