Add smooth player height control #519
Conversation
There was a problem hiding this comment.
Tested this in and out as it delivers a much needed feature that the XR Tools are lacking
*a way to prevent the players head from moving thru ceilings and blockade spots
Now this PR adds the above and some more as it accounts for the physical height change when the player suddenly stands up, the effect ingame is that the player is still under the blockade spot.
I might be biased as i was working on and off on a way to do just that but was to much locked in the idea of inducing a motion sickness way to do this, however since i had the chance to test this implementation and compare it to similar ideas in unity, i can say that this is it. It works and accounts for sitting/standing up and vice versa without breaking the immersion.
One thing i would like to request would be to add this to the possible 2.1 HotFix as it paths the way for other things such as the Seating PR #462 to work in a more homogeneous way
|
I don't see much problems althrou the hand gui could have box for making finger straight, I keep bumping into my hand with it nor straight, well I guess it is not from this merge req... |
|
Added a YouTube video showing the new behavior. |
Malcolmnixon
force-pushed
the
smooth-crouch
branch
from
935f1a7 to
d80ffba
Compare
|
I can confirm this fixes my issue #480 with both plane collisions and terrain collisions. However, if I jump while uncrouching, it seems to have the side effect of jump boosting when you jump during the smooth uncrouching. This could be a feature, but not in all cases of controller. |
Smoothly blend between player-controlled-height and software-override-height. Block player-height from growing when blocked by a low ceiling. Prevent double-jumping when jumping and standing-up at the same time.
Malcolmnixon
force-pushed
the
smooth-crouch
branch
from
d80ffba to
49a2c79
Compare
|
I tracked down the jump-boosting to a double-jump and prevented it with a better "standing on the ground" test. |
|
lgtm, no double jump noticed :) |
This pull request cleans up crouching and fixes issues #384 and #480 by:
The following video demonstrates its behavior in the test scenes - https://youtu.be/D43q14dIUKc