Adapts plugin structure to new Android v2, adds working permission flow #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, just need to fix some formatting and fix the build instructions in the CI so CI properly compiles things. |
BastiaanOlij
reviewed
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the plugin structure to the new v2 architecture, adds required files and compiles with ARCore as a dependency.
It adds a working download flow for ARCore (when ARCore is not already installed) and asks for the camera permission after that.
It also includes some C++ code that triggers ARCores tracking and a demo scene showing the tracking (https://www.youtube.com/shorts/hveT2O9lc1o)