Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Code cleanup for the export logic #118

Merged

Conversation

m4gr3d
Copy link
Collaborator

@m4gr3d m4gr3d commented Apr 6, 2024

Update the export logic so that export plugin objects are handed through references instead of using memnew and memfree

(cherry picked from #80 commit e946c3a)

Fixes #67 for the 2.x branch

@m4gr3d m4gr3d added bug Something isn't working cherry-pick labels Apr 6, 2024
@m4gr3d m4gr3d added this to the 2.0.4 milestone Apr 6, 2024
Update the export logic so that export plugin objects are handed through references instead of using `memnew` and `memfree`

(cherry picked from commit e946c3a)
@m4gr3d m4gr3d force-pushed the cherry_pick_export_logic_code_cleanup_2x branch from f469d84 to 2ad91fd Compare April 6, 2024 04:19
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m4gr3d m4gr3d merged commit 6ece887 into GodotVR:2.x Apr 6, 2024
5 checks passed
@m4gr3d m4gr3d deleted the cherry_pick_export_logic_code_cleanup_2x branch April 6, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants