Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the plugin version for the export plugins #75

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix the plugin version for the export plugins #75

merged 1 commit into from
Jan 18, 2024

Conversation

m4gr3d
Copy link
Collaborator

@m4gr3d m4gr3d commented Jan 18, 2024

The previous logic relied on EditorPlugin::get_plugin_version(), whose value became empty once we switched to gdextension and removed the plugin.cfg config file.

@m4gr3d m4gr3d added this to the 2.0.3 milestone Jan 18, 2024
dsnopek
dsnopek approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@m4gr3d m4gr3d merged commit 4962575 into GodotVR:master Jan 18, 2024
5 checks passed
@m4gr3d m4gr3d deleted the fix_export_plugin_version branch January 18, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@Malcolmnixon Malcolmnixon Awaiting requested review from Malcolmnixon

@BastiaanOlij BastiaanOlij Awaiting requested review from BastiaanOlij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@m4gr3d @dsnopek