-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repackage xpore & add Yuk Kei's CI #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Leon, (tagging you here @lrauschning)
Can you provide the screenshots of the following to the PR comments (just for record keeping) before I merge this to xpore's dev branch:
head diffmod.table
from running the 1) master branch 2) your branchwc -l diffmod.table
from running the 1) master branch 2) your branchmd5sum /absolute/path/to/diffmod.table
from running the 1) master branch 2) your branchls -lh dataprep
from running the 1) master branch 2) your branch
Thanks!
Can have a look after lunch. |
Here's the output:
|
The different md5sums seem to be due to different ordering of the kmers, all of the lines are identical:
I suspect the ordering is non-deterministic due to multithreading. E: Yes, after sorting the files are exactly the same:
I guess if extending the CI to cover this test case, we should be careful to include some kind of a sorting step. |
Basically what it says on the tin, modernizes the packaging as
setup.py
is considered deprecated now.Also took the opportunity to clean up some parts of the code and update some depenencies (eg numpy, pandas to version 2) and add the CI Yuk Kei had in the upstream dev branch.