-
Notifications
You must be signed in to change notification settings - Fork 0
Issue: (#1) 폴더 구조 예시 추가 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
개요이 PR은 변경 사항
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/kotlin/gomushin/backend/auth/presentation/ApiPath.kt (1)
3-4
: 빈 객체 ApiPath에 대한 주의.
현재ApiPath
객체는 기능을 구현하지 않은 빈 객체입니다. 만약 이후 API 경로와 관련된 상수나 메서드를 추가할 예정이라면, 추후 확장을 위한 TODO 주석이나 간단한 설명을 추가하는 것이 좋겠습니다. 이는 detekt 경고를 완화하는 동시에, 코드의 의도를 명확히 하는 데 도움이 됩니다.🧰 Tools
🪛 detekt (1.23.7)
[warning] 3-4: The class or object ApiPath is empty.
(detekt.empty-blocks.EmptyClassBlock)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/kotlin/gomushin/backend/auth/presentation/ApiPath.kt
(1 hunks)
🧰 Additional context used
🪛 detekt (1.23.7)
src/main/kotlin/gomushin/backend/auth/presentation/ApiPath.kt
[warning] 3-4: The class or object ApiPath is empty.
(detekt.empty-blocks.EmptyClassBlock)
🔇 Additional comments (1)
src/main/kotlin/gomushin/backend/auth/presentation/ApiPath.kt (1)
1-2
: 패키지 선언 확인.
패키지 선언 구문은 명확하게 작성되어 있으며, 네임스페이스도 올바르게 세팅되어 있습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~/value하고, ~/infrastructure에는 어떤 역할을 하는 클래스들이 담기는지 궁금해!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기에는 controller역할을 하는 클래스가 담긴다고 이해하면 될까?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기에는 controller역할을 하는 클래스가 담긴다고 이해하면 될까?
맞아!
Value 에는 VO를 넣으면 되는데, 아래 블로그 참고하면 더 이해하기 쉬울 듯!! 이런 값들 + Enum 이정도로 넣어 나는! https://ksh-coding.tistory.com/m/83 infrastructure 는 외부에서 사용하는 라이브러리 코드나, interface 구현체 정도! 만약 OpenAI를 쓰거나 OCR을 쓰면 해당 구현체 들을 넣으면 돼! |
✅ PR 유형
어떤 변경 사항이 있었나요?
📝 작업 내용
이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)
auth
✏️ 관련 이슈
🎸 기타 사항 or 추가 코멘트
하다가 헷갈리면 물어봐!!
Summary by CodeRabbit