Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoodDollar verification shown for wallet that is not Face Verified #191

Open
2 tasks done
decentralauren opened this issue Apr 10, 2024 · 5 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working P2 - Medium Issues that should be addressed but are not urgent.

Comments

@decentralauren
Copy link

decentralauren commented Apr 10, 2024

Issue

GoodDollar verification icon is showing for this wallet, which is not Face Verified and should not show as G$ verified. Wallet address 0x94aC950965731f71FA1a1666Beb48216dbA73E09

Screenshot 2024-04-10 at 6.13.22 PM.png

Fix

Show GoodDollar verification icon only when connected wallet has passed face verification.

  • add a whitelist check to WalletProfilePage
  • Depending on decision on graph, fetch from their, or call contract
@decentralauren decentralauren added bug Something isn't working P2 - Medium Issues that should be addressed but are not urgent. labels Apr 10, 2024
@L03TJ3 L03TJ3 self-assigned this Jul 8, 2024
@decentralauren
Copy link
Author

@L03TJ3 - this bug fix can get picked up in sprint if you have bandwidth.

@sirpy sirpy assigned sirpy and unassigned L03TJ3 Oct 7, 2024
sirpy added a commit that referenced this issue Oct 7, 2024
#191 [Bug] "Claim Celo Domain" shows for wallet with Celo Domain; Celo Domain not displayed #190
@sirpy
Copy link
Contributor

sirpy commented Oct 7, 2024

@decentralauren
if no ens or G$ profile
image.png

have G$ profile but no ens
image.png

ens no G$ profile
image.png

if has both ens and G$ profile name+ens will be shown without address.
in all cases:

  • profile header is clickable and leads to celoscan
  • profile image is generated based on wallet address via "robohash.org" - a random robot image based on wallet address

@decentralauren
Copy link
Author

@sirpy this is great, thank you. Does this also resolve the issue of the G$ "verified" logo only showing for addresses that are FV'd?

@sirpy
Copy link
Contributor

sirpy commented Oct 10, 2024

@decentralauren yes

@decentralauren
Copy link
Author

@vldkhh please test (please review comments as this ticket covers more than what was included in the original description).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 - Medium Issues that should be addressed but are not urgent.
Projects
None yet
Development

No branches or pull requests

4 participants