-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: supertoken protocol nft upgrade + celo gas token #269
Conversation
Other than the comments I mentioned, everything else looks in order! new storage is in the correct slots and other logic related to the NFT contracts have been properly added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes you've made here in the SuperGoodDollar and SuperToken contracts as a result of the new Flow NFT feature and v1.5.2 of ethereum-contracts ensures that SuperGoodDollar has access to these new features.
address from, | ||
address feeRecipient, | ||
address gatewayFeeRecipient, | ||
address communityFund, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this parameter is kinda legacy as fees will soon not be sent to the community fund, so maybe we can update that to baseFeeAddress
or something like that.
Took a look at the code and from a high level view, it seems like they do what it's expected from them. We could try to deploy this to an staging testnet to see how it behaves. |
@martinvol how can we deploy that to alfajores? |
Description
See superfluid NFT upgrade:
superfluid-finance/protocol-monorepo#1274
See Celo instructions for gas token compatability: