Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a global "please sign tx in your wallet" modal #417

Open
sirpy opened this issue May 17, 2023 · 2 comments
Open

create a global "please sign tx in your wallet" modal #417

sirpy opened this issue May 17, 2023 · 2 comments
Assignees
Labels

Comments

@sirpy
Copy link
Contributor

sirpy commented May 17, 2023

  • based on usedapp notifications
  • when a tx is in the waiting for sig state show a modal
  • once a tx is in pending state you can then trigger the toast for txs
@L03TJ3
Copy link
Collaborator

L03TJ3 commented Mar 22, 2024

@decentralauren not sure what to do with this or how to give it a 'priority-level'.
This is about what was discussed for user-feedback on gooddapp (including toasts).
and a more general implementation of transaction modals.

  1. this only relates to anything that has been build since celo-launch (claim flow / buy-gd / microbridge)
  2. nothing from any old(er) features can benefit from this
  3. currently we only have the claim-flow live and already has a sign-tx modal in the flow

@decentralauren
Copy link
Contributor

@L03TJ3 OK so the only benefit to implementing toasts now is for the claim flow to have a pending confirmation after the transaction is signed? Doesn't seem useful at this time, though adding toasts in the future may be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants