Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve transaction feedback #90

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Jun 14, 2023

Description

  • - add global sign-tx modal (what is now used scoped in claim-button)
  • - make global sign modal props/styling customizable
  • - replace local sign modal in claim-flow with global sign modal

About # (link your issue here)
#79
GoodDollar/GoodProtocolUI#417

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

@L03TJ3 L03TJ3 added the on hold label Jun 23, 2023
@L03TJ3 L03TJ3 mentioned this pull request Jan 25, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant