Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

456 goodid modal #105

Merged
merged 11 commits into from
Sep 12, 2023
Merged

456 goodid modal #105

merged 11 commits into from
Sep 12, 2023

Conversation

L03TJ3
Copy link
Collaborator

@L03TJ3 L03TJ3 commented Aug 31, 2023

Description

Modal + component for showing face-id sig

About # (link your issue here)
GoodDollar/GoodProtocolUI#456

Screens

As per requested UI
(desktop)
image

(mobile)
image

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

dev-release Show resolved Hide resolved
@L03TJ3 L03TJ3 marked this pull request as ready for review September 1, 2023 10:06
dev-release Show resolved Hide resolved
packages/sdk-v2/src/sdk/claim/sdk.ts Outdated Show resolved Hide resolved
@sirpy
Copy link
Contributor

sirpy commented Sep 6, 2023

@L03TJ3 what is this?
I constantly see PRs without a description and without being connected to an issue

@L03TJ3 L03TJ3 merged commit 87f333d into master Sep 12, 2023
1 check passed
@L03TJ3 L03TJ3 deleted the 456-goodid-modal branch September 12, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants