This repository was archived by the owner on Mar 8, 2018. It is now read-only.
BACKWARDS INCOMPATIBLE: Hash instances by object id rather than value #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouge8
force-pushed
the
feature/hash-by-id
branch
from
6111274 to
a87acbf
Compare
This patch updates our usage of `attr.s` to set `hash=False`, so that we use id-based hashing instead of value-based hashing. attrs 17.1.0 changed the default for `hash` to `None`, which makes objects unhashable. We set `hash=False` so that we can continue to use objects as keys in dictionaries, but without attempting to hash by value. http://www.attrs.org/en/stable/changelog.html
rouge8
force-pushed
the
feature/hash-by-id
branch
from
a87acbf to
4de6df0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates our usage of
attr.sto sethash=False, so that we use id-based hashing instead of value-based hashing.attrs 17.1.0 changed the default for
hashtoNone, which makes objects unhashable. We sethash=Falseso that we can continue to use objects as keys in dictionaries, but without attempting to hash by value.http://www.attrs.org/en/stable/changelog.html