Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppeteer testing tutorial #1016

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Add Puppeteer testing tutorial #1016

merged 3 commits into from
Oct 12, 2023

Conversation

oliverdunk
Copy link
Member

Adds an example Puppeteer test. This forms part of the new tutorial I am working on for developer.chrome.com.

As part of this I also renamed a file in showHistory, to make it clearer it's the popup, and added a key so the test can rely on that extension having a fixed ID.

@oliverdunk oliverdunk requested a review from AmySteam October 11, 2023 12:59
@oliverdunk oliverdunk assigned AmySteam and unassigned sebastianbenz Oct 11, 2023
Copy link
Contributor

@AmySteam AmySteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

## Overview

This is the sample code for the [Testing Chrome Extensions with Puppeteer](https://developer.chrome.com/docs/extensions/mv3/tut_puppeteer-testing/) tutorial.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a line about which extension this is testing? the history/showHistory?

@AmySteam AmySteam merged commit b25a56b into main Oct 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants