Power/keepawake: Split into basic/advanced and add popup to select which mode, and configurable timeout #1115
Conversation
nielm
force-pushed
the
main
branch
2 times, most recently
from
54e7bbe to
c697327
Compare
|
@nielm Thanks for the PR! I look forward to publishing the enhancements. As this is a samples library, would you be open to making this an "advanced" version of the sample? Just have you version be a separate folder, like we have in fontSettings. I plan on publishing your changes to the published version once we merge this in. |
Keep backward compatible behavior, and add a context menu option to show the popup.
nielm
changed the title
Done. There are now 2 subdirectories of I tried to preserve the history of both, but Git is not so good at doing that! |
|
@oliverdunk I'm not sure why I was pegged as the only reviewer for this. LGTM on the README. |
|
@patrickkettner, would you be comfortable reviewing this given your existing thread? |
oliverdunk
requested review from
patrickkettner
and removed request for
oliverdunk
|
Ping? |
When a keepawake with autodisable timeeout is active, show the message "Automatically disable at HH:MM" in the popup
This PR branches the power 'keepAwake' sample extension into a simple basic extension, and an advanced extension.
The advanced extension adds a popup menu and configurable timeout.
There is a context menu option to disable this popup, and revert to the classical behavior where the state is rotatated when the icon is clicked (like the basic version does)
Thre is also a context menu option to explicitly open the popup