Remove unneeded install command. (#3427)

* Remove unneeded install command. * Update playwright Dockerfile version. Make dependabot track Dockerfile updates (#3429) * Update playwright Dockerfile version Without this commit: `npm install` runs and installs the version in package.json which was 1.39 while the preinstalled browsers targeted playwright 1.37. Now that we are relying on the already installed libraries and browsers, we can get rid of the npm install in the Dockerfile too. TODO: Modify [dependabot](https://github.com/GoogleChrome/chromium-dashboard/blob/main/.github/dependabot.yml) to update the docker image. This should help prevent package.json playwright from outpacing the docker file image. * Update dependabot.yml to track Dockerfile updates * try * final --------- Co-authored-by: James C Scott III <[email protected]>
GoogleChrome · Oct 19, 2023 · 6aeec90 · 6aeec90
1 parent bf29516
commit 6aeec90
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -15,3 +15,13 @@ updates:
     reviewers:
       - "kyleju"
       - "jrobbins"
+  - package-ecosystem: "docker"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    commit-message:
+      # Prefix all commit messages with "docker"
+      prefix: "docker"
+    reviewers:
+      - "jrobbins"
+      - "jcscottiii"
diff --git a/packages/playwright/.dockerignore b/packages/playwright/.dockerignore
@@ -0,0 +1 @@
+node_modules
diff --git a/packages/playwright/Dockerfile b/packages/playwright/Dockerfile
@@ -1,4 +1,4 @@
-FROM mcr.microsoft.com/playwright:v1.37.1-jammy
+FROM mcr.microsoft.com/playwright:v1.39.0-jammy
 
 ARG USERID
 ARG GROUPID
@@ -18,6 +18,6 @@ USER pwuser
 WORKDIR /work
 # Cache the infrequent but time consuming changes early
 COPY --chown=pwuser:pwuser package.json /work/
-RUN npm install -D && npx playwright install
+RUN npm install -D
 # Copy the rest
 COPY --chown=pwuser:pwuser . /work