Fix confidential and product category fields not being set when creat…

…ing enteprrise feature (#4650) The field were not properly being set because they were not passed to the FeatureEntry constructor
GoogleChrome · Dec 20, 2024 · e495689 · e495689
1 parent 3fa4464
commit e495689
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/client-src/elements/form-field-specs.ts b/client-src/elements/form-field-specs.ts
@@ -498,7 +498,6 @@ export const ALL_FIELDS: Record<string, Field> = {
     choices: ENTERPRISE_PRODUCT_CATEGORY,
     label: 'Enterprise product category',
     help_text: html` Select the appropriate category.`,
-    check: (_value, getFieldValue) => checkFeatureNameAndType(getFieldValue),
   },
 
   feature_type: {

diff --git a/pages/guide.py b/pages/guide.py
@@ -170,6 +170,8 @@ def process_post_data(self, **kwargs):
         screenshot_links=self.parse_links('screenshot_links'),
         first_enterprise_notification_milestone=enterprise_notification_milestone,
         blink_components=[settings.DEFAULT_ENTERPRISE_COMPONENT],
+        confidential=self.form.get('confidential') == 'on',
+        enterprise_product_category=int(self.form.get('enterprise_product_category', '0')),
         tag_review_status=core_enums.REVIEW_NA)
     key: ndb.Key = feature_entry.put()
     search_fulltext.index_feature(feature_entry)