Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend changes for OT registration approvals #3444

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

DanielRyanSmith
Copy link
Collaborator

@DanielRyanSmith DanielRyanSmith commented Oct 24, 2023

This PR adds new fields to the OT creation request UI to facilitate the registration approvals settings for new origin trials.

The new fields are only available by selecting the checkbox for "Trial participation requires approval".

Screen.Recording.2023-10-25.at.11.23.10.AM.mov

@DanielRyanSmith DanielRyanSmith force-pushed the 2023-10-23_ot-registration-approvals branch from 5e682d1 to 06d79a9 Compare October 24, 2023 23:16
@DanielRyanSmith DanielRyanSmith changed the base branch from main to 2023-10-24_ot-registration-approval-fields October 24, 2023 23:16
Base automatically changed from 2023-10-24_ot-registration-approval-fields to main October 25, 2023 22:17
@DanielRyanSmith DanielRyanSmith requested a review from past October 25, 2023 22:21
Copy link
Collaborator

@past past left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment below.

client-src/elements/form-field-specs.js Outdated Show resolved Hide resolved
@DanielRyanSmith DanielRyanSmith force-pushed the 2023-10-23_ot-registration-approvals branch from 6142517 to 7f12a0a Compare October 30, 2023 16:05
@DanielRyanSmith DanielRyanSmith marked this pull request as ready for review October 30, 2023 16:12
Copy link
Collaborator

@jrobbins jrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after making one wording fix

client-src/elements/form-field-specs.js Outdated Show resolved Hide resolved
@DanielRyanSmith DanielRyanSmith merged commit 320f8d9 into main Nov 2, 2023
7 checks passed
@DanielRyanSmith DanielRyanSmith deleted the 2023-10-23_ot-registration-approvals branch November 2, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants