Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out LaCrOS enum value #4617

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Phase out LaCrOS enum value #4617

merged 2 commits into from
Dec 6, 2024

Conversation

jrobbins
Copy link
Collaborator

@jrobbins jrobbins commented Dec 6, 2024

The enterprise team requested that the LaCrOS platform option should no longer be offered when rolling out features, but it should still remain for past rollouts.

We cannot simply remove the LaCrOS option, because it is still needed for old rollouts to display a string rather than an int or nothing.

In this PR:

  • Introduce the concept of an obsolete enum value, and mark LaCrOS as obsolete.
  • When constructing sl-select options, don't include obsolete options unless they are part of the current field value.

@jrobbins jrobbins requested a review from KyleJu December 6, 2024 00:30
@jrobbins jrobbins merged commit 1ac4356 into main Dec 6, 2024
7 checks passed
@jrobbins jrobbins deleted the 20241205-phase-out-lacros-enum branch December 6, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants