Remove screenshot_links from enterprise creation page. #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleJu
approved these changes
Dec 12, 2024
jrobbins
deleted the
20241212-remove-screenshot_links-from-enterprise-creation-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new attachments functionality stores attachments associated with a given feature entry ID. So, the feature needs to already exist before we can attach anything to it. On the feature creation page, we can't have this field yet because there is no defined feature ID.
It should be an OK UX to attach the screenshots on the next page after creating the feature entry. The existing flow is already taking the user directly from the creation page to the editing page. So, users can attach screenshots on a page that they already are automatically navigated to.