Add a confidential field to policies #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yanndago
commented
Dec 17, 2024
yanndago
commented
- Add a new confidential field to features
- This new field makes it impossible to:
- access the feature via direct url
- find the feature using search
- See the feature in the release notes
- The only users who can see a confidential feature are admins, owners of a google.com and chromium.org account, feature owners, editors and creators.
yanndago
force-pushed
the
confidentiality
branch
from
c80f832 to
be2ff15
Compare
jrobbins
reviewed
Dec 17, 2024
| type: 'checkbox', | ||
| label: 'Confidential', | ||
| initial: false, | ||
| help_text: html `This is a confidential feature that should not be publicly |
There was a problem hiding this comment.
It would be more clear if this explained who could view the feature. E.g., "@google.com accounts, @chromium.org accounts, the feature owners, and editors."
framework/permissions.py
Outdated
| return not feature.confidential or can_view_confidential_feature(user, feature) | ||
|
|
||
| def can_view_confidential_feature(user, feature): | ||
| ''' Check if the user is an owner, editor, spec mentor, or creator |
There was a problem hiding this comment.
Nit: all our other docstrings use three double-quotes.
yanndago
force-pushed
the
confidentiality
branch
from
aa0f186 to
24b0db3
Compare
yanndago
force-pushed
the
confidentiality
branch
from
24b0db3 to
9aa4b5c
Compare
jrobbins
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.