Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display SLO for review resolutions. #4662

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

jrobbins
Copy link
Collaborator

@jrobbins jrobbins commented Jan 1, 2025

Display the SLO info for review resolutions. Previously we were only displaying SLO info for the reviewers' initial response. We recently implemented and deployed logic to track more fields related to review resolution. This PR exposes those fields in the API and UI.

In this PR:

  • Add resolution-related fields to the API converters and openapi spec.
  • Fix some of the client-side types that are expected for these fields.
  • Rewrite the rendering logic. Instead of displaying one line of SLO info, it will now display two lines. The first is always the SLO for the initial response. The second line can give SLO info for resolution, or show that the gate is in the NEEDS_WORK state since a specific date.

@jrobbins jrobbins requested a review from KyleJu January 1, 2025 01:11
@jrobbins jrobbins merged commit d6c38b1 into main Jan 3, 2025
7 checks passed
@jrobbins jrobbins deleted the 20241231-display-slo-resolution-time branch January 3, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants