Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new notification when OT approvals are obtained #4685

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DanielRyanSmith
Copy link
Collaborator

@DanielRyanSmith DanielRyanSmith commented Jan 10, 2025

Fixes #4520

@DanielRyanSmith DanielRyanSmith marked this pull request as ready for review January 13, 2025 18:26
Copy link
Collaborator

@jrobbins jrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one grammar suggestion.

Comment on lines +683 to +684
"""Notify about an origin trial having received reviews and approvals and is
ready to request creation."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Notify about an origin trial having received reviews and approvals and is
ready to request creation."""
"""Notify about an origin trial having received reviews and approvals and being
ready for the user to request creation."""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants