Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"OT approved" email bug fix #4753

Merged
merged 1 commit into from
Jan 31, 2025
Merged

"OT approved" email bug fix #4753

merged 1 commit into from
Jan 31, 2025

Conversation

DanielRyanSmith
Copy link
Collaborator

This change fixes a bug related to the automated email sent when an origin trial is approved. The incorrect arguments were supplied for the build_email method.

Copy link
Collaborator

@jrobbins jrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't mypy catch this?

@jrobbins
Copy link
Collaborator

Why didn't mypy catch this?

Ah, the body of process_post_data() was not checked because that function does not have any type info in its signature. We should probably add a bunch more return types throughout our existing code.

@DanielRyanSmith
Copy link
Collaborator Author

Why didn't mypy catch this?

I think this is because the feature and contacts variables are technically returned as untyped. This may have been flagged by mypy if I explicitly gave a type to these two vars.

@DanielRyanSmith DanielRyanSmith merged commit f8ea4fe into main Jan 31, 2025
7 checks passed
@DanielRyanSmith DanielRyanSmith deleted the 2025-01-31_bugfix branch January 31, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants