Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update related_website_sets.JSON #738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edwardgoodnow
Copy link

THink I dd this right am not sure

Copy link

google-cla bot commented Jan 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

],
"rationaleBySite": {
"https://www.pennyauctionsoftware.net": "https://www.pennyauctionsoftware.net",
"https://demo.pennyauctionsoftware.net": "https://demo.pennyauctionsoftware.net"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this set is for testing purposes. We recommend using the local testing capabilities for RWS instead: https://developers.google.com/privacy-sandbox/blog/first-party-sets-testing-instructions#how_to_test_locally.

@arichiv
Copy link
Member

arichiv commented Jan 28, 2025

It looks like you haven’t updated this PR in a while. Your PR will close in 14 days if there aren’t any updates or comments on this PR.

Copy link

github-actions bot commented Feb 4, 2025

The RWS JSON was not successfully validated. Here are your results:
Formatting for JSON is incorrect;
error was:

--- PR file
+++ expected
@@ -1,16 +1,16 @@
 {
   "sets": [
     {
-       "contact": "[email protected]",
-       "primary": "https://pennyauctionsoftware.net",
-       "associatedSites": [
-          "https://www.pennyauctionsoftware.net",
-          "https://demo.pennyauctionsoftware.net"
-       ],
-       "rationaleBySite": {
-          "https://www.pennyauctionsoftware.net": "https://www.pennyauctionsoftware.net",
-          "https://demo.pennyauctionsoftware.net": "https://demo.pennyauctionsoftware.net"
-       }
+      "contact": "[email protected]",
+      "primary": "https://pennyauctionsoftware.net",
+      "associatedSites": [
+        "https://www.pennyauctionsoftware.net",
+        "https://demo.pennyauctionsoftware.net"
+      ],
+      "rationaleBySite": {
+        "https://www.pennyauctionsoftware.net": "https://www.pennyauctionsoftware.net",
+        "https://demo.pennyauctionsoftware.net": "https://demo.pennyauctionsoftware.net"
+      }
     },
     {
       "contact": "[email protected]",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants