-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update related_website_sets.JSON #738
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
], | ||
"rationaleBySite": { | ||
"https://www.pennyauctionsoftware.net": "https://www.pennyauctionsoftware.net", | ||
"https://demo.pennyauctionsoftware.net": "https://demo.pennyauctionsoftware.net" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this set is for testing purposes. We recommend using the local testing capabilities for RWS instead: https://developers.google.com/privacy-sandbox/blog/first-party-sets-testing-instructions#how_to_test_locally.
It looks like you haven’t updated this PR in a while. Your PR will close in 14 days if there aren’t any updates or comments on this PR. |
The RWS JSON was not successfully validated. Here are your results: --- PR file
+++ expected
@@ -1,16 +1,16 @@
{
"sets": [
{
- "contact": "[email protected]",
- "primary": "https://pennyauctionsoftware.net",
- "associatedSites": [
- "https://www.pennyauctionsoftware.net",
- "https://demo.pennyauctionsoftware.net"
- ],
- "rationaleBySite": {
- "https://www.pennyauctionsoftware.net": "https://www.pennyauctionsoftware.net",
- "https://demo.pennyauctionsoftware.net": "https://demo.pennyauctionsoftware.net"
- }
+ "contact": "[email protected]",
+ "primary": "https://pennyauctionsoftware.net",
+ "associatedSites": [
+ "https://www.pennyauctionsoftware.net",
+ "https://demo.pennyauctionsoftware.net"
+ ],
+ "rationaleBySite": {
+ "https://www.pennyauctionsoftware.net": "https://www.pennyauctionsoftware.net",
+ "https://demo.pennyauctionsoftware.net": "https://demo.pennyauctionsoftware.net"
+ }
},
{
"contact": "[email protected]",
|
THink I dd this right am not sure