This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Warn developers about absolute/relative UVC controls #4941
Merged
beaufortfrancois
merged 2 commits into
GoogleChrome:main
from
beaufortfrancois:uvc-absolute
Mar 30, 2021
Merged
Warn developers about absolute/relative UVC controls #4941
beaufortfrancois
merged 2 commits into
GoogleChrome:main
from
beaufortfrancois:uvc-absolute
Mar 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Staging URLsFor your convenience, here are direct links (on our staging site) to the content you created or updated: Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
beaufortfrancois
added
the
content update
for issues that do not require new content (only for updates to existing content)
label
Mar 22, 2021
beaufortfrancois
force-pushed
the
uvc-absolute
branch
from
March 22, 2021 15:23
64ab730
to
9945f48
Compare
Deploy preview for web-dev-staging ready! Built with commit 64ab730 |
riju
approved these changes
Mar 22, 2021
Deploy preview for web-dev-staging ready! Built with commit d347095 |
jpmedley
suggested changes
Mar 23, 2021
Co-authored-by: Joe Medley <[email protected]>
@jpmedley I've committed your suggestion. Please review. |
jpmedley
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I've been out of the office.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
Contributor has signed the CLA
content update
for issues that do not require new content (only for updates to existing content)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about updating the "Control camera pan, tilt, and zoom" blog post with a note on Chromium using the absolute UVC controls, not the relative ones. This will hopefully reduce developer confusion as seen in w3c/mediacapture-image#263 (comment).