Add concurrent batch writer + have browser feature support event use it #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
force-pushed
the
jcscottiii/concurrent-batch-events
branch
2 times, most recently
from
f48ec6e
to
48cd67f
Compare
jcscottiii
force-pushed
the
jcscottiii/concurrent-batch-events
branch
from
48cd67f
to
3bd1974
Compare
Base automatically changed from
jcscottiii/batch-writer
to
web-features-service-to-job
November 11, 2024 21:58
jcscottiii
force-pushed
the
web-features-service-to-job
branch
from
ed07bda
to
032b5bc
Compare
jcscottiii
changed the base branch from
web-features-service-to-job
to
jcscottiii/batch-writer
jrobbins
approved these changes
Nov 11, 2024
Base automatically changed from
jcscottiii/batch-writer
to
web-features-service-to-job
November 12, 2024 14:29
This change adds a generic concurrent batch writer. During testing in GCP, I saw that each batch write call has a limit but we can increase throughput by running concurrent batch writes. By default, we set the batch size to 10000 entities and 8 concurrent batch writers. In the future, we can allow spanner clients to configure these based on system settings.
jcscottiii
force-pushed
the
jcscottiii/concurrent-batch-events
branch
from
3bd1974
to
7178d69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a generic concurrent batch writer. This calls the BatchWriteMutations method from #889
Background: During testing in GCP, I saw that each batch write call has a limit but we can increase throughput by running concurrent batch writes.
By default, we set the batch size to 10000 entities and 8 concurrent batch writers. In the future, we can allow spanner clients to configure these based on system settings.