feat: implement browsingContext.historyUpdated

GoogleChromeLabs · Oct 2, 2024 · 5f6a2b7 · 5f6a2b7
1 parent 97dc759
commit 5f6a2b7
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 12 deletions.
diff --git a/src/bidiMapper/modules/context/BrowsingContextImpl.ts b/src/bidiMapper/modules/context/BrowsingContextImpl.ts
@@ -425,19 +425,36 @@ export class BrowsingContextImpl {
       this.#url = params.url;
       this.#navigation.withinDocument.resolve();
 
-      this.#eventManager.registerEvent(
-        {
-          type: 'event',
-          method: ChromiumBidi.BrowsingContext.EventNames.FragmentNavigated,
-          params: {
-            context: this.id,
-            navigation: this.#navigationId,
-            timestamp,
-            url: this.#url,
+      if (params.navigationType === 'fragment') {
+        this.#eventManager.registerEvent(
+          {
+            type: 'event',
+            method: ChromiumBidi.BrowsingContext.EventNames.FragmentNavigated,
+            params: {
+              context: this.id,
+              navigation: this.#navigationId,
+              timestamp,
+              url: this.#url,
+            },
           },
-        },
-        this.id
-      );
+          this.id
+        );
+      }
+      if (params.navigationType === 'historyApi') {
+        this.#eventManager.registerEvent(
+          {
+            type: 'event',
+            // @ts-expect-error missing types
+            method: "browsingContext.historyUpdated",
+            // @ts-expect-error missing types
+            params: {
+              context: this.id,
+              url: this.#url,
+            },
+          },
+          this.id
+        );
+      }
     });
 
     this.#cdpTarget.cdpClient.on('Page.frameStartedLoading', (params) => {

diff --git a/src/protocol/chromium-bidi.ts b/src/protocol/chromium-bidi.ts
@@ -131,6 +131,7 @@ export const EVENT_NAMES = new Set([
   ...Object.values(Log.EventNames),
   ...Object.values(Network.EventNames),
   ...Object.values(Script.EventNames),
+  'browsingContext.historyUpdated'
   // keep-sorted end
 ]);