-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Bluetooth Emulation BiDi mapping #2624
Open
alexnj
wants to merge
9
commits into
GoogleChromeLabs:main
Choose a base branch
from
alexnj:bt-bidi-mapper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+221
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
alexnj
commented
Sep 18, 2024
alexnj
changed the title
WIP: Implement Bluetooth Emulation BiDi mapping
Implement Bluetooth Emulation BiDi mapping
Sep 19, 2024
OrKoN
approved these changes
Sep 19, 2024
OrKoN
changed the title
Implement Bluetooth Emulation BiDi mapping
feat: Implement Bluetooth Emulation BiDi mapping
Sep 19, 2024
sadym-chromium
approved these changes
Sep 19, 2024
Lightning00Blade
changed the title
feat: Implement Bluetooth Emulation BiDi mapping
feat: implement Bluetooth Emulation BiDi mapping
Sep 25, 2024
The CDDL generated portions are hardcoded and will be removed once generated fro spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Bluetooth Emulation spec from WebBluetoothCG/web-bluetooth#630. Needs to wait until spec is landed before this can be merged.