Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rely on Network.requestWillBeSent to detect navigation start #2863

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

chore: rely on Network.requestWillBeSent to detect navigation start #2863

wants to merge 16 commits into from

Commits on Dec 3, 2024

  1. Add NavigationTracker and emit NavigationStarted from it

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    b5a7df6 View commit details
    Browse the repository at this point in the history

  2. NavigationAborted through NavigationTracker

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    9ca2729 View commit details
    Browse the repository at this point in the history

  3. remove pendingCommandNavigation

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    5c20d92 View commit details
    Browse the repository at this point in the history

  4. remove navigation.withinDocument + markNavigationFailed

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    5d098c4 View commit details
    Browse the repository at this point in the history

  5. fix test_print_top_level_context 

    WPT `test_with_beforeunload_prompt` failing
    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    87895c8 View commit details
    Browse the repository at this point in the history

  6. FragmentNavigated + NavigationFailed

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    14df88d View commit details
    Browse the repository at this point in the history

  7. Move NavigationTracker to a dedicated file

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    5e6b3ca View commit details
    Browse the repository at this point in the history

  8. test: assert all the navigation events during redirection

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    df2214d View commit details
    Browse the repository at this point in the history

  9. test helpers

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    3fed13c View commit details
    Browse the repository at this point in the history

  10. Rely on Network.requestWillBeSent event to detect navigation started.

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    cf1c190 View commit details
    Browse the repository at this point in the history

  11. Tolerate multiple requestWillBeSent events for a single request

    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    2624af9 View commit details
    Browse the repository at this point in the history

  12. test: update the expectations for PR (#2864) 

    Automatically generated by
https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
    @browser-automation-bot
    browser-automation-bot authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    d94993b View commit details
    Browse the repository at this point in the history

  13. Tolerate multiple requestWillBeSent events for a single request 

    handle beforeunload
    @sadym-chromium
    sadym-chromium committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    c734236 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. test: update the expectations for PR (#2866) 

    Automatically generated by
https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
    @browser-automation-bot
    browser-automation-bot authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    cb9d15c View commit details
    Browse the repository at this point in the history

  2. Start navigation if CDP command finished

    @sadym-chromium
    sadym-chromium committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    994e10f View commit details
    Browse the repository at this point in the history

  3. test: update the expectations for PR (#2870) 

    Automatically generated by
https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
    @browser-automation-bot
    browser-automation-bot authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    e9bd47f View commit details
    Browse the repository at this point in the history