Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol parser with Input schemas #781

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

jrandolf-2
Copy link
Contributor

Bug: #749

@jrandolf-2 jrandolf-2 requested a review from OrKoN May 26, 2023 06:18
@jrandolf-2 jrandolf-2 mentioned this pull request May 26, 2023
29 tasks
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget that auto-merge would land it into another branch instead of main.

Base automatically changed from input-module-1 to main May 26, 2023 06:38
@jrandolf-2 jrandolf-2 enabled auto-merge (squash) May 26, 2023 06:59
@jrandolf-2 jrandolf-2 merged commit 760986c into main May 26, 2023
@jrandolf-2 jrandolf-2 deleted the input-module-2 branch May 26, 2023 07:14
const AnglePropertiesSchema = zod.object({
altitudeAngle: zod
.number()
.min(0.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, prefer nonnegative().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants