Initial Input module implementation #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf-2
force-pushed
the
input-module-5
branch
from
c693126
to
22149dd
Compare
jrandolf-2
force-pushed
the
input-module-4
branch
from
f193b3b
to
3871396
Compare
jrandolf-2
force-pushed
the
input-module-5
branch
from
22149dd
to
67b487b
Compare
OrKoN
reviewed
May 26, 2023
jrandolf-2
force-pushed
the
input-module-5
branch
2 times, most recently
from
480ffc5
to
0f41670
Compare
jrandolf-2
force-pushed
the
input-module-5
branch
2 times, most recently
from
6b94d5e
to
e1c1b2b
Compare
|
Do we need to update some WPT expectations to see if the WPT tests pass? @sadym-chromium |
OrKoN
reviewed
May 26, 2023
jrandolf-2
force-pushed
the
input-module-5
branch
2 times, most recently
from
eb0d1d3
to
bb35958
Compare
|
@OrKoN Yea, we should update the WPT tests. I've added appended the headless tests, but should we do the others as well? |
OrKoN
approved these changes
May 26, 2023
jrandolf-2
force-pushed
the
input-module-5
branch
from
bb35958
to
ae5b179
Compare
jrandolf-2
force-pushed
the
input-module-5
branch
from
ae5b179
to
5371dcb
Compare
jrandolf-2
force-pushed
the
input-module-5
branch
from
5371dcb
to
592ae58
Compare
sadym-chromium
approved these changes
May 26, 2023
thiagowfx
reviewed
May 26, 2023
|
|
||
| # TODO(jrandolf): Investigate mouse wheel flakiness. The deltaY sometimes | ||
| # doubles and other times not. It is also not independent of the mouse. | ||
| # @pytest.mark.asyncio |
There was a problem hiding this comment.
Please use @pytest.mark.skip(reason="TODO: Implement") instead of submitting commented out code
thiagowfx
reviewed
May 26, 2023
thiagowfx
reviewed
May 26, 2023
| from anys import ANY_STR | ||
| from test_helpers import execute_command, goto_url | ||
|
|
||
| SCRIPT_HTML = 'data:text/html,' + """ |
There was a problem hiding this comment.
Define the script without data:text/html. Then, in the test function, add the html fixture and use it as html(SCRIPT)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes to the reviewer:
Bug: #749