update how inputs are passed to ensure all new props are forwarded as… #24
Conversation
src/utils/index.test.ts
Outdated
| }; | ||
|
|
||
| const inputs = { | ||
| id: '123', |
There was a problem hiding this comment.
If we pass in inputs like { id: "props.id" } will that be inlined the same? We should highlight that in the test to make it clear
There was a problem hiding this comment.
Do you mean if the value is a clear string like "props.id"? It'll inline the same way:
<iframe id="props.id"></iframe>Or are you referring to a templating logic here?
| @@ -8,6 +8,7 @@ | |||
| "loading": "lazy", | |||
| "src": { | |||
| "url": "https://www.google.com/maps/embed/v1/place", | |||
There was a problem hiding this comment.
Should this be "https://www.google.com/maps/embed/v1/"
So when we pass slugParam it would be appended correctly
There was a problem hiding this comment.
I set up slugParam to replace the last slug so that /place is the default, but I can change the logic if that would make more sense? This way, without specifying mode will still result in this default URL
|
|
||
| const result = formatData(data, inputs); | ||
| expect(result.html).toEqual( | ||
| '<iframe loading="auto" src="https://www.example.com/?id=props.id" width="150" height="100"></iframe>', |
There was a problem hiding this comment.
I'm not sure if this is right src="https://www.example.com/?id=props.id" since it appends id=props.id and I was thinking it would be like id={props.id}
I think I might be misunderstanding these tests and we don't have to do this. I can test the actual api once updated and revisit this later.
There was a problem hiding this comment.
Yeah let me merge this in for you so you can test it out
| attributes: { | ||
| loading: 'lazy', | ||
| src: { | ||
| url: 'https://www.google.com/maps/embed/v1/place', |
There was a problem hiding this comment.
Oh, does this replace only the last part of the url?
This PR does the following:
Fixes Forward remaining arguments #23. This PR updates how inputs are handled to always forward additional arguments/properties provided by the user if they don't exist somewhere in the schema (as a URL param or already specified default attribute).
For example: A React consumer that specifies
<GoogleMapsEmbed ... randomAttr="123"/>will result in<iframe ... randomAttr="123">Fixes Support
mapModeas a user parameter for Google Maps #25. Introduces aslugParamproperty to the schema that when defined by the user, either appends or replaces the slug in thesrcattribute URLFor example, currently the
srcURL for the Google Maps Embed export ishttps://www.google.com/maps/embed/v1/place, but a newslugParamwith a value ofmodewas added.--> If a React consumer specifies
<GoogleMapsEmbed ... mode="view" />, the output becomes<iframe ... src="[123](https://www.google.com/maps/embed/v1/view">